Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce API calls by 50% by only using dnddeutsch.de #8

Closed
Wayneoween opened this issue Apr 25, 2019 · 1 comment
Closed

reduce API calls by 50% by only using dnddeutsch.de #8

Wayneoween opened this issue Apr 25, 2019 · 1 comment
Assignees
@Wayneoween
Labels
enhancement New feature or request

Comments

@Wayneoween
Copy link
Owner

There is a (until recently undocumented) feature on the dnddeutsch API that has all the data we could want.

A sample query looks like this: https://www.dnddeutsch.de/tools/json.php?q=goblin&o=monster

We don't have to use colly to scrape dndbeyond, we can just make 1 API Call and then on "enter" go to the dndbeyond monster statblock!
@Wayneoween Wayneoween added the enhancement New feature or request label Apr 25, 2019
@Wayneoween Wayneoween self-assigned this Apr 25, 2019
Wayneoween added a commit that referenced this issue May 1, 2019
@Wayneoween
WIP: #8 dnddeutsch API
eea1aac
Wayneoween added a commit that referenced this issue May 1, 2019
@Wayneoween
WIP: #8 dnddeutsch API
321657b
@Wayneoween Wayneoween mentioned this issue May 2, 2019
Merged
@Wayneoween
Copy link
Owner Author

Closed by 0.6 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wayneoween Wayneoween

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Wayneoween