adds #register and #deregister to Service #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhamelink
added a commit
that referenced
this pull request
May 7, 2015
Add #register and #deregister to Service
|
Hey @qzio 😄 First off, thanks for using consul, and thanks even more for contributing! I've taken a look at what you have, and it was a really good start. I've merged it and made some changes which you can see here: I modified your PR so that the register & deregister methods return true or false, added comments and updated the spec to pass. Thanks again! JH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to have this feature.
Not sure about the implementation though, let me know if I should change anything.