【1.1.15】Fix Datatype Decimal Error #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casionone
reviewed
Aug 31, 2023
| @@ -62,7 +63,7 @@ object DataType extends Logging { | |||
| case "date" => DateType | |||
| case "timestamp" => TimestampType | |||
| case "binary" => BinaryType | |||
| case "decimal" | DECIMAL_REGEX() => DecimalType | |||
| case "decimal" | DECIMAL_REGEX() | DECIMAL_REGEX_BLANK() => DecimalType | |||
| case ARRAY_REGEX() => ArrayType | |||
There was a problem hiding this comment.
^decimal\\(\\d*\\,\\d*\\)
^decimal\\(\\s*\\d*\\s*,\\s*\\d*\\s*\\)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
When trino queries a table containing a decimal field, the metadata of that field is converted to a string
Reason：
The column type returned by trino is decimal (10, 8), containing spaces. Regular matching converted to DecimalType does not support spaces, so the default conversion is to string.
Related issues/PRs
Related issues: apache#4892
Brief change log
Checklist