Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix important mismatch for getting the right mock #31

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Fix important mismatch for getting the right mock #31

merged 1 commit into from
Nov 13, 2019

Conversation

AvdLee
Copy link
Contributor

@AvdLee AvdLee commented Nov 12, 2019

Classic mistake, a small typo. Added a test to reproduce the issue so we don't do this again.

@AvdLee AvdLee self-assigned this Nov 12, 2019
@ghost
Copy link

ghost commented Nov 12, 2019

1 Message
📖 Errors: Executed 16 tests, with 0 failures (0 unexpected) in 1.763 (1.774) seconds

Current coverage for Mocker.framework is 88.00%

Files changed - -
MockingURLProtocol.swift 82.19% ✅
Mock.swift 84.44% ✅

Powered by xcov

Generated by 🚫 Danger

kairadiagne
kairadiagne approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@kairadiagne kairadiagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@AvdLee AvdLee merged commit fa052c0 into master Nov 13, 2019
@AvdLee AvdLee deleted the feature/match-fix branch November 13, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boris-Em Boris-Em Boris-Em approved these changes

@kairadiagne kairadiagne kairadiagne approved these changes

Assignees

@AvdLee AvdLee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AvdLee @Boris-Em @kairadiagne