-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mixing in the ability to send an explicit error from a mock response #52
Conversation
Mocker.framework: Coverage: 89.02
Generated by 🚫 Danger Swift against 56c30a4 |
@heckj thanks for your contribution! I'd love to adjust the code a bit, update the documentation and add some tests. If you would be able to add that, we can merge this in! |
I can definitely do that - might be a few days, but hopefully not as long as the first wait ;-) |
cd1f6ab
to
56c30a4
Compare
This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days. |
👋 @AvdLee - I updated this PR a while ago, so I think it's just waiting on your approval for anything further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great! Sorry for not coming back to this any earlier. I think it slipped through somehow!
Congratulations! 🎉 This was released as part of Release 2.2.0 🚀 Generated by GitBuddy |
for feedback/review:
this is done primarily In order to test error handling - which comes in useful when you're building declarative pipelines that do just that with something like Combine. A recent thread in a closed issue (#24) made me think it might be useful to submit. There aren't any tests yet against this with these changes, but if this looks useful to y'all, I would be happy to create the relevant updates