Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixing in the ability to send an explicit error from a mock response #52

Merged
merged 3 commits into from
May 22, 2020

Conversation

heckj
Copy link
Contributor

@heckj heckj commented Apr 17, 2020

for feedback/review:

this is done primarily In order to test error handling - which comes in useful when you're building declarative pipelines that do just that with something like Combine. A recent thread in a closed issue (#24) made me think it might be useful to submit. There aren't any tests yet against this with these changes, but if this looks useful to y'all, I would be happy to create the relevant updates

@ghost
Copy link

ghost commented Apr 18, 2020

Warnings
⚠️

Consider to place some MARK: lines for Sources/Mock.swift, which is over 200 lines big.

Messages
📖

View more details on Bitrise

📖 Mocker: Executed 18 tests, with 0 failures (0 unexpected) in 1.690 (1.754) seconds

Mocker.framework: Coverage: 89.02

File Coverage
MockingURLProtocol.swift 86.27%
Mock.swift 84.62%

Generated by 🚫 Danger Swift against 56c30a4

Sources/Mock.swift Outdated Show resolved Hide resolved
@AvdLee
Copy link
Contributor

AvdLee commented Apr 20, 2020

@heckj thanks for your contribution! I'd love to adjust the code a bit, update the documentation and add some tests. If you would be able to add that, we can merge this in!

@heckj
Copy link
Contributor Author

heckj commented Apr 20, 2020

I can definitely do that - might be a few days, but hopefully not as long as the first wait ;-)

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label May 21, 2020
@heckj
Copy link
Contributor Author

heckj commented May 21, 2020

👋 @AvdLee - I updated this PR a while ago, so I think it's just waiting on your approval for anything further.

Copy link
Contributor

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! Sorry for not coming back to this any earlier. I think it slipped through somehow!

@AvdLee AvdLee merged commit 036f58f into WeTransfer:master May 22, 2020
@AvdLee AvdLee mentioned this pull request May 22, 2020
@ghost
Copy link

ghost commented May 25, 2020

Congratulations! 🎉 This was released as part of Release 2.2.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants