Use millis since epoch when calling set_queue_start #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😍
… On 10 Jul 2019, at 11:12, Andrei Horak ***@***.***> wrote:
So, this PR fixes this by providing the actual millis since epoch (as provided by SQS), as an integer
|
julik
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This didn't previously work, because we were calling
transaction.set_queue_startwith aTimeobject, whereas this is a lower-level method that only accepts integers.SentTimestampfrom an SQS message returns millis since epoch. Appsignal converts times to integers, and dispatches them to the C library in the same way. So, this PR fixes this by providing the actual millis since epoch (as provided by SQS), as an integer.