Skip to content
This repository has been archived by the owner on Nov 3, 2020. It is now read-only.

fix: sanitize filenames and upload based on filename #138

Merged
merged 1 commit into from
Oct 17, 2018
Merged

fix: sanitize filenames and upload based on filename #138

merged 1 commit into from
Oct 17, 2018

Conversation

arkaitzgarro
Copy link
Contributor

@arkaitzgarro arkaitzgarro commented Oct 16, 2018 •
edited
Loading

Proposed changes

This change solves the following issues:

  • WeTransfer doesn't support overly wide UTF-8 chars on filenames, like emojis, so we need to sanitize the filename before sending it to the API.
  • The order how files are uploaded is based on the order the user provides the files, which could not be the order the API is returning the files. Now we upload the files based on (sanitized) files name.

Closes #136

Types of changes

  • Docs (missing or updated docs)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement / maintenance (removing technical debt, performance, tooling, etc...)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if appropriate)
  • Code changes are covered by unit tests.
  • Any dependent changes have been merged and published in downstream modules

@arkaitzgarro arkaitzgarro mentioned this pull request Oct 16, 2018
Closed
@arkaitzgarro arkaitzgarro merged commit 7f68e48 into master Oct 17, 2018
@delete-merged-branch delete-merged-branch bot deleted the fix-file-upload-order branch October 17, 2018 08:21
ulisessp pushed a commit that referenced this pull request Oct 17, 2018
@semantic-release-bot
chore(release): 0.6.1 [skip ci]
b7afa62 
## [0.6.1](v0.6.0...v0.6.1) (2018-10-17)

### Bug Fixes

* **deps:** update dependency lodash to v4.17.11 ([#122](#122)) ([5cea200](5cea200))
* **deps:** update dependency winston to v3.1.0 ([#117](#117)) ([a9f37cc](a9f37cc))
* sanitize filenames and upload based on filename ([#138](#138)) ([7f68e48](7f68e48))
ulisessp pushed a commit that referenced this pull request Oct 17, 2018
@semantic-release-bot
chore(release): 1.0.1 [skip ci]
adb869d 
## [1.0.1](v1.0.0...v1.0.1) (2018-10-17)

### Bug Fixes

* sanitize filenames and upload based on filename ([#138](#138)) ([7f68e48](7f68e48))
@ghost
Copy link

ghost commented Oct 17, 2018

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arnoFleming arnoFleming mentioned this pull request Oct 18, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidenko87 davidenko87 davidenko87 approved these changes

@arnoFleming arnoFleming Awaiting requested review from arnoFleming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transfer API uploading files in wrong order
2 participants
@arkaitzgarro @davidenko87