-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify copyright holder #1
Comments
The brackets shouldn't actually be filled in inside the LICENSE file. I can't find a counter example of this. Really what we need is to include the boiler plate (with the brackets filled in) inside all the source files. But ugh. There's also the possibility of NOTICE.txt, but I'm not sure that's the right answer. |
Oh, perhaps this doesn't actually matter for Apache. It's a common mistake for GPL code. You can tell I never use Apache. |
* Fix regexp pattern to match expected items - Fixes the regex patterns to not capture text like "a*" or "*a"; accomplish this by using re.MULTILINE and "^\w+$" as the capture pattern instead of raw '\w+' - Formatting in spacing for re.VERBOSE comments in the regex pattern construction; explicitly defines the 'flags=' kwarg in the re.compile() calls. * Modularize duplicated function-level variables Coalesces and shifts two identical instances of the full regexp pattern for determining valid blacklist tags to a module-level pattern; reduces the number of places duplicate code exists for ease of maintenance.
merge in charmander's marketplace design changes
Might want to fix that.
The text was updated successfully, but these errors were encountered: