-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Single Blog Post UI #215
Conversation
✅ Deploy Preview for webdevpathstage ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
It looks good, but it seems the PR is not ready, if that's the case, you can change this to a draft PR I understand
I believe you can change the the color in the SVG code |
Thanks for checking Cheryl. I switched it to draft. This task is for the UI part. I believe someone else will take over this branch once my part is done. I will play with the SVG color to match the Figma file. |
Hey, @Satoshi-Sh ! That's a great start, thanks! Here are a few points we need to work on here:
Please let me know if that makes sense! |
Thanks for checking @mariana-caldas . We don't want to merge this branch into the main until we implement the dev to API part. Should I keep this as a draft even though I'm done?
I replaced S.Container with Container except for the AuthorBio container and S.Title with Title. Does this look fine? About other headings and paragraphs, do we have any other components I can use here?
I just moved the sample data to the util folder for better visibility. |
This is looking so much better, @Satoshi-Sh ! I think we're almost there with this UI; great job so far! Two points to have in mind:
Your PR gave me a cool idea for a blog post btw 🙏🏼 . Getting started with a new codebase to implement features. Any thoughts @cherylli ? |
I forgot to mention about it. I need to override the default style of the Container. That's why I kept the new Container. In the new commit, I use an overridden Container. Does it look fine?
I'm not sure about this instruction. It would be great if you could give me an example. P.S. Do you mean I just need to use the default (defined in GlobalStyles) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, everything works fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Satoshi-Sh ! 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good and it's working properly. Great job @Satoshi-Sh
Have you updated the CHANGELOG.md file? If not, please do it.
Yes, I did.
What is this change?
Made a single blog post page according to the Figma file created by @kimbercash .
Were there any complications while making this change?
If necessary, please describe how to test the new feature or fix.
Please go to
/blog/post/1
. You need to type it in the url. You can see the page with my sample blog post from dev.to.Comments
Screenshot
When should this be merged?
After dev.to API is incorporated.