Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 updates #97

Merged
merged 34 commits into from
Mar 15, 2023
Merged

v5 updates #97

merged 34 commits into from
Mar 15, 2023

Conversation

shahbaz17
Copy link
Member

No description provided.

@shahbaz17
Copy link
Member Author

shahbaz17 commented Mar 13, 2023

@yashovardhan Please test a few of the combinations here.

I tested all of the @web3auth/modal and most @web3auth/no-modal examples.

Copy link
Member

@yashovardhan yashovardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good to merge. Just a few things that are mentioned here need to update. Also we cannot merge this until 5.0.0 production version is out.

package.json Outdated
@@ -2,7 +2,7 @@
"name": "root",
"private": true,
"scripts": {
"update-web3auth": "lerna exec --concurrency 1 -- 'ncu -u @web3auth/*'",
"update-web3auth": "lerna exec --concurrency 1 -- 'ncu --pre 5.0.0-alpha.0 -u @web3auth/*'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to remove this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll do it before merging once we have a major release of this.

@@ -1,7 +1,7 @@
/** @type {import('next').NextConfig} */
const nextConfig = {
reactStrictMode: true,
swcMinify: true,
// swcMinify: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this fixing this build?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahbaz17 shahbaz17 merged commit 17cc435 into main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants