-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5 updates #97
v5 updates #97
Conversation
SMS login addChain switchChain
ReferenceError: window is not defined
@yashovardhan Please test a few of the combinations here. I tested all of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good to merge. Just a few things that are mentioned here need to update. Also we cannot merge this until 5.0.0 production version is out.
package.json
Outdated
@@ -2,7 +2,7 @@ | |||
"name": "root", | |||
"private": true, | |||
"scripts": { | |||
"update-web3auth": "lerna exec --concurrency 1 -- 'ncu -u @web3auth/*'", | |||
"update-web3auth": "lerna exec --concurrency 1 -- 'ncu --pre 5.0.0-alpha.0 -u @web3auth/*'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll do it before merging once we have a major release of this.
@@ -1,7 +1,7 @@ | |||
/** @type {import('next').NextConfig} */ | |||
const nextConfig = { | |||
reactStrictMode: true, | |||
swcMinify: true, | |||
// swcMinify: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this fixing this build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.