Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dynamic-imports #1869

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Feat/dynamic-imports #1869

merged 3 commits into from
Jul 9, 2024

Conversation

chaitanyapotti
Copy link
Member

@chaitanyapotti chaitanyapotti commented Jul 9, 2024

Motivation and Context

This PR aims to fix the build issues related to dynamic imports in react apps (cra & vite)

Description

  • Removes the dynamic imports

How has this been tested?

Developer tested this manually.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hieu-w hieu-w self-requested a review July 9, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants