Add ref.cast_nop_static #4656
Merged
Add ref.cast_nop_static #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unsafe experimental instruction is semantically equivalent to ref.cast_static, but V8 will unsafely turn it into a nop. This is meant to help us measure cast overhead more precisely than we can by globally turning all casts into nops.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
kripken
approved these changes
May 10, 2022
src/wasm-builder.h
Outdated
| @@ -810,10 +810,12 @@ class Builder { | |||
| ret->finalize(); | |||
| return ret; | |||
| } | |||
| RefCast* makeRefCast(Expression* ref, HeapType intendedType) { | |||
| RefCast* | |||
| makeRefCast(Expression* ref, HeapType intendedType, bool unsafe = false) { | |||
There was a problem hiding this comment.
This could be an enum perhaps, Safe/Unsafe or Checked/Unchecked or such?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unsafe experimental instruction is semantically equivalent to
ref.cast_static, but V8 will unsafely turn it into a nop. This is meant to help
us measure cast overhead more precisely than we can by globally turning all
casts into nops.