Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outlining] Add loop instruction support #6141

Merged
merged 3 commits into from
Dec 7, 2023
Merged

[Outlining] Add loop instruction support #6141

merged 3 commits into from
Dec 7, 2023

Conversation

ashleynh
Copy link
Collaborator

@ashleynh ashleynh commented Nov 30, 2023

Adds support for the loop instruction to be outlined and a test showing a repeat loop being outlined.

Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ better title + message

@ashleynh ashleynh changed the base branch from spr/ashleynh-main.loops to main December 7, 2023 09:42
Created using spr 1.3.4
@ashleynh ashleynh changed the title loops [Outlining] Add loop instruction support Dec 7, 2023
@ashleynh ashleynh changed the title [Outlining] Add loop instruction support [Outlining] Add loop instruction Dec 7, 2023
@ashleynh ashleynh changed the title [Outlining] Add loop instruction [Outlining] Add loop instruction to existing builder Dec 7, 2023
@ashleynh ashleynh changed the title [Outlining] Add loop instruction to existing builder [Outlining] Add loop instruction capability Dec 7, 2023
@ashleynh ashleynh changed the title [Outlining] Add loop instruction capability [Outlining] Add loop instruction support Dec 7, 2023
@ashleynh ashleynh merged commit 2049ee8 into main Dec 7, 2023
14 checks passed
@ashleynh ashleynh deleted the spr/ashleynh-loops branch December 7, 2023 10:15
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
Adds support for the loop instruction to be outlined and a test showing a repeat loop being outlined.

Reviewers: tlively

Reviewed By: tlively

Pull Request: WebAssembly#6141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants