Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update formal spec to (partially) implement the 3rd EH proposal #180

Merged
merged 13 commits into from
Aug 26, 2022
Merged

Update formal spec to (partially) implement the 3rd EH proposal #180

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4bd749a
Update core formal spec to the current (3rd) EH proposal
ioannad Sep 7, 2021
a34f14f
Apply suggestions from code review
ioannad May 27, 2022
7c4f707
Addressed some of the review comments.
ioannad Jul 6, 2022
d21ac52
Finished addressing review comments.
ioannad Aug 11, 2022
4e77107
Remerged two arrays in folded instructions, realigned, added missing …
ioannad Aug 11, 2022
7e68070
Added forgotten fix by Andreas Rossberg.
ioannad Aug 11, 2022
d6664e3
Update document/core/util/macros.def
ioannad Aug 24, 2022
1e71e0d
Update document/core/text/instructions.rst
ioannad Aug 24, 2022
56c2506
Addressed two forgotten review comments.
ioannad Aug 24, 2022
e9de07d
Addressed currently last review comment and added |-markers forgotten…
ioannad Aug 24, 2022
53e4e33
Fixed stray + signs that were breaking the build, added missing `)`.
ioannad Aug 24, 2022
4d30c9b
Apply suggestions from code review
ioannad Aug 26, 2022
86126ae
Addressed latest two review comments.
ioannad Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions document/core/util/macros.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,11 +909,11 @@
.. |CLABELS| mathdef:: \xref{valid/conventions}{context}{\K{labels}}
.. |CRETURN| mathdef:: \xref{valid/conventions}{context}{\K{return}}
.. |CREFS| mathdef:: \xref{valid/conventions}{context}{\K{refs}}
.. |LCATCH| mathdef:: \xref{valid/conventions}{valid-labeltype}{\mathrel{\K{catch}}}
.. |LCATCH| mathdef:: \xref{valid/conventions}{context}{\mathrel{\K{catch}}}

.. Contexts, non-terminals

.. |labeltype| mathdef:: \xref{valid/conventions}{valid-labeltype}{\mathrel{\X{labeltype}}}
.. |labeltype| mathdef:: \xref{valid/conventions}{context}{\mathrel{\X{labeltype}}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these have an additional \mathrel that other entries above don't have?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I had added it when these two were under "Notation" a few lines above, where the other two entries also had \mathrel. Removing it in a followup commit of this PR.



.. Judgments
Expand Down