Small fixes on formal spec overview/examples #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheejin
commented
Feb 16, 2022
| @@ -153,11 +153,11 @@ Use the trivial throw context `T` again, this time to match the throw to the `ca | |||
| Location of a rethrown exception. Let `x, y, z` be tag indices of tags with type `[t_x]→[]`, `[t_y]→[]`, and `[t_z]→[]` respectively. Let `val_p : t_p` for every `p` among `x, y, z`. | |||
|
|
|||
| ``` | |||
| try | |||
| try $label2 | |||
There was a problem hiding this comment.
I think$label2 should be here, given that it points to this try's corresponding catch.. No?
- Removes a link next to `[1]`. The link is also in the footnote so it's not strictly necessary, and adding a link right next to `[1]` makes `[]` disappear, so it appears as just `1`, which isn't probably what the author intended. - Both of `throw/catch x` and `throw/catch $x` are being used. Unified them into `throw/catch $x`. - Fixes a location of `$label2` in a test. - Removes `_m` from `catch` and `caught` administrative instructions in Exceptions-formal-examples.md. They were only removed in the overview.
aheejin
force-pushed
the
formal_md_fix
branch
from
a30dd5c
to
55480a9
Compare
ioannad
approved these changes
Feb 17, 2022
|
Next time I'd appreciate if let me merge my own PRs! :) (Not a big deal for sure, but I don't usually use commit messages provided by Github that's the list of all commits within the PR.) |
|
Apologies, will do so from now on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1]. The link is also in the footnote so it'snot strictly necessary, and adding a link right next to
[1]makes[]disappear, so it appears as just1, which isn't probably whatthe author intended.
throw/catch xandthrow/catch $xare being used. Unifiedthem into
throw/catch $x.$label2in a test._mfromcatchandcaughtadministrative instructions inExceptions-formal-examples.md. They were only removed in the overview.