Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Agenda for sync meeting 1/22/21 #419

Closed
tlively opened this issue Jan 8, 2021 · 5 comments
Closed

Agenda for sync meeting 1/22/21 #419

tlively opened this issue Jan 8, 2021 · 5 comments

Comments

@tlively
Copy link
Member

tlively commented Jan 8, 2021

The next meeting will be Friday, January 22 at 9:00AM - 10:00AM PST/ 6:00PM - 7:00PM CET. Please respond with agenda items you would like to discuss.

If this meeting doesn't already appear on your calendar, or you are a new attendee, please fill out this form to attend.

Agenda so far:

@penzn
Copy link
Contributor

penzn commented Jan 8, 2021

We had another item on agenda for today - the cost model. IMO it probably lower in priority to everything on the list, but can complement the optimization discussion.

Also, what about i64x2 min and max (#417, #418)?

@tlively
Copy link
Member Author

tlively commented Jan 11, 2021

Thanks, min and max were accidental omissions from my list. I've been putting off the cost model discussion for now because it doesn't block moving to phase 4. It's an important conversation to have, though. After the phase 4 vote I expect that there will be a good amount of additional optimization, documentation, and cleanup work to do on the tools side.

@Maratyszcza
Copy link
Contributor

New instructions with experimental data to discuss:

@lars-t-hansen
Copy link
Contributor

Given where we are wrt work load and looming phase 4 deadline, we might consider scheduling another meeting next week.

@tlively
Copy link
Member Author

tlively commented Jan 22, 2021

Thanks for a productive meeting, everyone! Here are the notes.

We conducted five votes this meeting:

  1. We had consensus that in subsequent discussions about whether to include particular instructions, we should assume engines will be able to recognize and optimize mask operands that were produced by comparison operations.
  2. We had consensus that i64x2.all_true (i64x2.all_true instructions #415) should be merged to the proposal.
  3. We had consensus that i64x2.eq (i64x2.eq instruction #381) should be merged to the proposal.
  4. We had consensus that i64x2.ne (i64x2.ne instruction #411) should be merged to the proposal.
  5. We did not have consensus that i64x2 signed comparisons should be merged to the proposal. They will not be added unless we get more data and revisit the discussion, but this is a low priority.

We also decided to meet again at the same time next week to discuss the agenda items we did not get to in this meeting.

@tlively tlively closed this as completed Jan 22, 2021
ghost pushed a commit to riscv-collab/v8 that referenced this issue Jan 26, 2021
This is merged into the proposal:
WebAssembly/simd#419 (comment).

Bug: v8:11215
Change-Id: Ibe37c4f8a977ab9af1cc2dd083f1ebb88b27acfa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2647986
Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72333}
pull bot pushed a commit to p-g-krish/v8 that referenced this issue Jan 27, 2021
Port 906b964

Original Commit Message:

    This is merged into the proposal:
    WebAssembly/simd#419 (comment).

R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com
BUG=
LOG=N

Change-Id: I801c4337e2ea4671ef82cb1244b8da251d56fc2f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650242
Reviewed-by: Zhi An Ng <zhin@chromium.org>
Commit-Queue: Milad Fa <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/master@{#72341}
pull bot pushed a commit to Alan-love/v8 that referenced this issue Feb 2, 2021
Port 910d92e

Original Commit Message:

    This is a partial revert of https://crrev.com/c/2457669 to add back
    i64x2.ne and i64x2.all_true, which were accepted into the proposal
    (WebAssembly/simd#419).

    This only implements it for x64 and arm64 on TurboFan, other archs and
    Liftoff will come later.

R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com
BUG=
LOG=N

Change-Id: I9aedc94f665a7e02426e0abe44cea72176063942
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2668830
Reviewed-by: Junliang Yan <junyan@redhat.com>
Reviewed-by: Milad Fa <mfarazma@redhat.com>
Commit-Queue: Milad Fa <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/master@{#72494}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants