Make memory_trap tests use addresses relative to memory_size... #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it behaves correctly regardless of the page_size that the implementation aligns memory_size to.
AndrewScheidecker
force-pushed
the
fix_memory_trap_tests
branch
from
9035128
to
5f8f251
Compare
|
lgtm, but you seem to have replaced spaces with tabs and the repo uses spaces. |
|
Oops, fixed. |
|
lgtm |
sunfishcode
added a commit
that referenced
this pull request
Oct 8, 2015
Make memory_trap tests use addresses relative to memory_size...
Connicpu
pushed a commit
to Connicpu/wasm-spec
that referenced
this pull request
May 11, 2020
This follows the recent JavaScript name change, and was decided in the Nov 13 CG meeting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…so that it behaves correctly regardless of the page_size that the implementation aligns memory_size to.