Add more tests, delete some redundant tests, and reorganize some existing tests. #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… expected approximation.
…afe optimization.
|
Ping :-). |
|
|
||
| (func $f64.no_fuse_reciprocal_sqrt (param $x f64) (result f64) | ||
| (f64.div (f64.const 1.0) (f64.sqrt (get_local $x)))) | ||
| (export "f64.no_fuse_reciprocal_sqrt" $f64.no_fuse_reciprocal_sqrt) |
There was a problem hiding this comment.
FWIW, you can now merge the export into the function def, avoiding all the repetition.
|
LGTM (mostly rubber-stamped). |
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 3, 2023
rossberg
pushed a commit
that referenced
this pull request
Jul 23, 2024
This reflects the WPT changes in web-platform-tests/wpt@5623804 web-platform-tests/wpt@e0c0429 and web-platform-tests/wpt#42764 `wasm-module-builder.js` was not fully synced with the WPT repo; the changes reflected were just enough to pass the tests. This also changes `worker` from `dedicatedworker` in `legacy/exceptions/js-api/basic.tentative.any.js`, even though the matching WPT test has not been updated to use it, because all other tests seem to be using `dedicatedworker` now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.