[document] First stab at specifying validation #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
reviewed
Mar 17, 2017
| All rules are given in two *equivalent* forms: | ||
|
|
||
| 1. In *prose*, describing the meaning in intuitive form. | ||
| 2. In *formal notation*, describing the rule in mathematical form. |
There was a problem hiding this comment.
When we discussed this, we agreed that formal notation would be placed in an appendix, rather than being used within the main document itself.
There was a problem hiding this comment.
Having spent some time scanning over this on a few occasions now, I think I really like this current interleaved formatting, for a few reasons:
- it seems easier to keep the two precisely coherent and spot discrepancies when they are juxtaposed
- as a future frequent user of this document, I'll definitely benefit from having the formal rules right next to bulleted explanation
- with the mini-tutorial given in conventions.html#formal-notation, I expect anyone not already familiar with the notation could pick it up by first observing the basic style and then learning by example from reading a few rules
- there's a pretty minimal impact on readability even if you just want to skip over it
- the interleaved heading / summary / notation / explanation form matches the "Structure" section which I also really like as is; in general, I think this is a good high-level style to use throughout the doc
IIRC, this also matches @dherman's recommendation last time we discussed this organizational question. Happy to have any comments from you too Dave.
* Fix tests to reflect new NaN semantics * Test that `select` and `if` return specific NaN bitpatterns.
|
Overall, lgtm. I'm expecting we'll iterate more as everything comes together. |
rossberg
added a commit
that referenced
this pull request
Mar 28, 2017
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
…mbly#445) Load lane and store lane instructions added in WebAssembly#350.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see test rendering on https://webassembly.github.io/spec/