Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set -D_POSIX_C_SOURCE for MINGW only #1360

Merged
merged 1 commit into from Mar 15, 2020
Merged

Set -D_POSIX_C_SOURCE for MINGW only #1360

merged 1 commit into from Mar 15, 2020

Conversation

rrrapha
Copy link
Contributor

@rrrapha rrrapha commented Mar 14, 2020

Resolves #1359

okuoku
okuoku reviewed Mar 14, 2020
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
okuoku
okuoku reviewed Mar 14, 2020
View reviewed changes
Copy link
Contributor

@okuoku okuoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this breaks Cygwin :)

MINGW can be MINGW OR CYGWIN . Unfortunately, it seems there is no (simple) way to check how the host handles __STRICT_ANSI__ .

@rrrapha
Copy link
Contributor Author

rrrapha commented Mar 14, 2020

But this breaks Cygwin :)

MINGW can be MINGW OR CYGWIN . Unfortunately, it seems there is no (simple) way to check how the host handles __STRICT_ANSI__ .

Thank you, I've changed it to MINGW OR CYGWIN.

binji
binji approved these changes Mar 15, 2020
View reviewed changes
Copy link
Member

@binji binji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm

@binji binji merged commit 261dfdd into WebAssembly:master Mar 15, 2020
@rrrapha rrrapha deleted the posix-c-source branch March 17, 2020 00:13
@orbea orbea mentioned this pull request Dec 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okuoku okuoku okuoku left review comments

@binji binji binji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation error on OpenBSD/clang
3 participants
@rrrapha @okuoku @binji