Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plain try with no catch or delegate #1676

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

takikawa
Copy link
Contributor

Recent changes in the exception handling proposal spec (WebAssembly/exception-handling#157) now allow a try block with no catch or other clauses (to reduce syntactic special cases). In this case, a try is identical to a block.

This PR adds support for this extra case.

@takikawa
Copy link
Contributor Author

Updated for compatibility with events->tag renaming.

@takikawa
Copy link
Contributor Author

@aheejin would you be a good person to review this patch? (ditto for #1675) I'd use "request review" but I think I can't use that feature on this repo.

Copy link
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed reply!

src/wast-parser.cc Outdated Show resolved Hide resolved
Matches recent changes in the exception handling spec that allowed
this case to reduce special cases in the syntax:

  WebAssembly/exception-handling#157
@takikawa
Copy link
Contributor Author

This is now rebased to fix conflicts (conflicted with unwind deletion PR).

Copy link
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aheejin aheejin merged commit 16ab434 into WebAssembly:main Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants