Allow catch/delegate-less trys #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was suggested here: WebAssembly#131 (comment) Closes WebAssembly#131.
aheejin
added a commit
to aheejin/binaryen
that referenced
this pull request
Jun 7, 2021
This removes the restriction that `try` should have at least one `catch`/`catch_all`/`delegate`. See WebAssembly/exception-handling#157.
aheejin
added a commit
to aheejin/binaryen
that referenced
this pull request
Jun 7, 2021
This removes the restriction that `try` should have at least one `catch`/`catch_all`/`delegate`. See WebAssembly/exception-handling#157.
tlively
approved these changes
Jun 7, 2021
Co-authored-by: Thomas Lively <7121787+tlively@users.noreply.github.com>
ioannad
approved these changes
Jun 7, 2021
ioannad
added a commit
to ioannad/exception-handling
that referenced
this pull request
Jun 8, 2021
In particular:
- The labels surrounding try-catch and try-delegate now get a standard
label in the first step, which is then refined to catch-labels and/or
try-labels per subblock.
+ For that I allowed the new administrative instructions to appear
nested directly inside a label_n{} in block contexts.
+ Also added a validation rule to the administrative label_n{}.
+ Due to this, all block contexts appear now without a successor
exponent.
- Updated to latest try-catch syntax described in issue WebAssembly#157.
- Corrected some previously wrong syntax.
- Removed try-unwind (...) as per issue WebAssembly#156
- Updated Exceptions-formal-examples.md similarly.
Ms2ger
pushed a commit
to Ms2ger/exception-handling
that referenced
this pull request
Jun 9, 2021
takikawa
approved these changes
Jun 9, 2021
aheejin
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Jun 11, 2021
This removes the restriction that `try` should have at least one `catch`/`catch_all`/`delegate`. See WebAssembly/exception-handling#157.
takikawa
added a commit
to takikawa/wabt
that referenced
this pull request
Jun 13, 2021
Matches recent changes in the exception handling spec that allowed this case to reduce special cases in the syntax: WebAssembly/exception-handling#157
takikawa
added a commit
to takikawa/wasm-tools
that referenced
this pull request
Jun 14, 2021
The exception handling spec now allows bare `try` blocks that have no corresponding `catch` (or other) clauses following it. These blocks are semantically equivalent to `block`. Related spec PR: WebAssembly/exception-handling#157
takikawa
added a commit
to takikawa/wasm-tools
that referenced
this pull request
Jun 15, 2021
The exception handling spec now allows bare `try` blocks that have no corresponding `catch` (or other) clauses following it. These blocks are semantically equivalent to `block`. Related spec PR: WebAssembly/exception-handling#157
alexcrichton
pushed a commit
to bytecodealliance/wasm-tools
that referenced
this pull request
Jun 15, 2021
The exception handling spec now allows bare `try` blocks that have no corresponding `catch` (or other) clauses following it. These blocks are semantically equivalent to `block`. Related spec PR: WebAssembly/exception-handling#157
Closed
takikawa
added a commit
to takikawa/wabt
that referenced
this pull request
Jun 22, 2021
Matches recent changes in the exception handling spec that allowed this case to reduce special cases in the syntax: WebAssembly/exception-handling#157
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 22, 2021
The proposal spec for exception handling was recently changed to allow a `try` block with no `catch` or `delegate` clauses: WebAssembly/exception-handling#157 Differential Revision: https://phabricator.services.mozilla.com/D118088
ioannad
added a commit
to ioannad/exception-handling
that referenced
this pull request
Jun 25, 2021
In particular:
- The labels surrounding try-catch and try-delegate now get a standard
label in the first step, which is then refined to catch-labels and/or
try-labels per subblock.
+ For that I allowed the new administrative instructions to appear
nested directly inside a label_n{} in block contexts.
+ Also added a validation rule to the administrative label_n{}.
+ Due to this, all block contexts appear now without a successor
exponent.
- Updated to latest try-catch syntax described in issue WebAssembly#157.
- Corrected some previously wrong syntax.
- Removed try-unwind (...) as per issue WebAssembly#156
- Updated Exceptions-formal-examples.md similarly.
takikawa
added a commit
to takikawa/wabt
that referenced
this pull request
Jun 29, 2021
Matches recent changes in the exception handling spec that allowed this case to reduce special cases in the syntax: WebAssembly/exception-handling#157
takikawa
added a commit
to takikawa/wabt
that referenced
this pull request
Jun 29, 2021
Matches recent changes in the exception handling spec that allowed this case to reduce special cases in the syntax: WebAssembly/exception-handling#157
aheejin
pushed a commit
to WebAssembly/wabt
that referenced
this pull request
Jun 30, 2021
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jul 16, 2021
The proposal spec for exception handling was recently changed to allow a `try` block with no `catch` or `delegate` clauses: WebAssembly/exception-handling#157 Differential Revision: https://phabricator.services.mozilla.com/D118088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was suggested here:
#131 (comment)
Closes #131.