Fix #2203 #2204
Merged
Fix #2203 #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithw
reviewed
Apr 20, 2023
keithw
reviewed
Apr 20, 2023
There was a problem hiding this comment.
lgtm. Thank you for working on this! Could you please submit the test to the exception-handling repo so it can get picked up by the testsuite repo and included in the WABT testsuite (#2203 (comment))?
Alternately, I think it would be fine to amend this PR to include that as a one-off test if you just want this to get merged ASAP, and we can merge the upstream testsuite fix down the road. Either way it would be nice to make sure this scenario gets tested so different implementations all agree on the behavior of mixing br with try/catch.
keithw
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(didn't test locally but should work)
Fixes #2203