Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename info to fd-info, and other minor fixes. #66

Merged
merged 2 commits into from
Nov 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions wasi-filesystem.abi.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Size: 8, Alignment: 8

Size: 8, Alignment: 8

## <a href="#info" name="info"></a> `info`: record
## <a href="#fd_info" name="fd_info"></a> `fd-info`: record

Information associated with a descriptor.

Expand All @@ -36,11 +36,11 @@ Size: 2, Alignment: 1

### Record Fields

- <a href="info.type" name="info.type"></a> [`type`](#info.type): [`type`](#type)
- <a href="fd_info.type" name="fd_info.type"></a> [`type`](#fd_info.type): [`type`](#type)

The type of filesystem object referenced by a descriptor.

- <a href="info.flags" name="info.flags"></a> [`flags`](#info.flags): [`flags`](#flags)
- <a href="fd_info.flags" name="fd_info.flags"></a> [`flags`](#fd_info.flags): [`flags`](#flags)

Flags associated with a descriptor.

Expand Down Expand Up @@ -657,8 +657,8 @@ Size: 16, Alignment: 8
##### Params

- <a href="#descriptor_fadvise.self" name="descriptor_fadvise.self"></a> `self`: handle<descriptor>
- <a href="#descriptor_fadvise.offset" name="descriptor_fadvise.offset"></a> `offset`: `u64`
- <a href="#descriptor_fadvise.len" name="descriptor_fadvise.len"></a> `len`: `u64`
- <a href="#descriptor_fadvise.offset" name="descriptor_fadvise.offset"></a> `offset`: [`filesize`](#filesize)
- <a href="#descriptor_fadvise.len" name="descriptor_fadvise.len"></a> `len`: [`size`](#size)
- <a href="#descriptor_fadvise.advice" name="descriptor_fadvise.advice"></a> `advice`: [`advice`](#advice)
##### Results

Expand Down Expand Up @@ -693,7 +693,7 @@ Size: 16, Alignment: 8
- <a href="#descriptor_info.self" name="descriptor_info.self"></a> `self`: handle<descriptor>
##### Results

- result<[`info`](#info), [`errno`](#errno)>
- result<[`fd-info`](#fd_info), [`errno`](#errno)>

----

Expand Down
12 changes: 6 additions & 6 deletions wasi-filesystem.wit.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ type filedelta = s64
type timestamp = u64
```

## `info`
## `fd-info`
```wit
/// Information associated with a descriptor.
///
/// Note: This was called `fdstat` in earlier versions of WASI.
record info {
record fd-info {
/// The type of filesystem object referenced by a descriptor.
%type: %type,
/// Flags associated with a descriptor.
Expand Down Expand Up @@ -413,15 +413,15 @@ resource descriptor {
/// This is similar to `posix_fadvise` in POSIX.
fadvise: func(
/// The offset within the file to which the advisory applies.
offset: u64,
offset: filesize,
/// The length of the region to which the advisory applies.
len: u64,
len: size,
/// The advice.
advice: advice
) -> result<_, errno>
```

## `fdatasync`
## `datasync`
```wit
/// Synchronize the data of a file to disk.
///
Expand All @@ -437,7 +437,7 @@ datasync: func() -> result<_, errno>
/// as additional fields.
///
/// Note: This was called `fdstat_get` in earlier versions of WASI.
info: func() -> result<info, errno>
info: func() -> result<fd-info, errno>
```

## `set-size`
Expand Down