Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake_build_type typo #382

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

Changqing-JING
Copy link
Contributor

@Changqing-JING Changqing-JING commented Feb 6, 2024

The cmake_build_type is wrongly spelled. When cmake receives as an invalid cmake_build_type, it won't add optimization flags such as -O2 to compiler command. Then the complication is unoptimized.

Copy link
Collaborator

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I confirmed from the CMake docs that this is the right change and searched through the Makefile to check that there were no other typos of this kind.

@Changqing-JING
Copy link
Contributor Author

Changqing-JING commented Feb 7, 2024

@abrown
I found the abort.c CI error which blocks recent PRs is not difficult to fix.
The problem is just the wasmtime is updated the 19.0.0 but the wasi_snapshot_preview1.command.wasm is still 16.0.0, which leads to the version mismatch. Since the wasm time is installed by --version dev, the wasi_snapshot_preview1.command.wasm can also be downloaded from the "dev" release. Then the problem can be solved.

The checks already passed locally on my machine. Could you help to rerun the CI?

@Changqing-JING
Copy link
Contributor Author

Changqing-JING commented Feb 9, 2024

@abrown ping ping, could you help to approve the CI. The CI error should be able fixed by this PR

@abrown
Copy link
Collaborator

abrown commented Feb 9, 2024

@Changqing-JING thanks for the reminder to look at this again and good find on the adapter incompatibility! I thought it was something related to that from a recent wasi-libc PR.

@abrown abrown enabled auto-merge (squash) February 10, 2024 00:54
@abrown abrown merged commit 52536f2 into WebAssembly:main Feb 10, 2024
5 checks passed
@Changqing-JING Changqing-JING deleted the bugfix/cmake_build_type_typo branch May 8, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants