Fix tests on WAMR #85
Conversation
zoraaver
force-pushed
the
fix-tests-on-wamr
branch
2 times, most recently
from
3d08a35
to
f443d26
Compare
| @@ -39,6 +39,12 @@ pub unsafe fn create_tmp_dir(dir_fd: wasi::Fd, name: &str) -> wasi::Fd { | |||
| | wasi::RIGHTS_FD_READDIR | |||
| | wasi::RIGHTS_FD_FILESTAT_GET | |||
| | wasi::RIGHTS_FD_SEEK | |||
| | wasi::RIGHTS_PATH_LINK_SOURCE | |||
There was a problem hiding this comment.
Given that those tests were passing on wasmtime, I wonder if wasmtime correctly implemented file right system. Looks like files created in parent directory inherit base rights, instead of inheriting inheriting rights. @abrown is that something you could confirm?
There was a problem hiding this comment.
Can you point me to which version of Wasmtime is being used to run the tests? I do see recent-ish PRs that may have changed this behavior:
There was a problem hiding this comment.
I would try the latest version of Wasmtime then and see if that resolves things?
There was a problem hiding this comment.
I just tried the latest main branch, and tests in its current form (e.g. path_filestat) are still passing.
There was a problem hiding this comment.
Looks like files created in parent directory inherit base rights, instead of inheriting inheriting rights.
Just want to confirm that's the behaviour I observed.
@abrown if it's helpful, here's a list of tests which should fail (without the changes from this PR) and the required missing rights:
path_link.rs
wasi::RIGHTS_PATH_LINK_SOURCE
wasi::RIGHTS_PATH_LINK_TARGET
wasi::RIGHTS_PATH_OPEN
wasi::RIGHTS_PATH_UNLINK_FILE
path_filestatandsymlink_filestat.rs
wasi::RIGHTS_PATH_FILESTAT_GET
f443d26
to
1278a9a
Compare
zoraaver
force-pushed
the
fix-tests-on-wamr
branch
3 times, most recently
from
3acc550
to
24d4f7f
Compare
zoraaver
force-pushed
the
fix-tests-on-wamr
branch
from
24d4f7f
to
1aaa4af
Compare
zoraaver
force-pushed
the
fix-tests-on-wamr
branch
from
1aaa4af
to
5ce1bdf
Compare
Most of the changes are adding rights to fix permissions issues and changing expected error codes.
I've also changed the
stdio.rstest so that the destination (to) file descriptors are valid. The test was previously failing on WAMR since the destination fd's were arbitrary numbers which seems to be explicitly not permitted by the docs. A test case has been added inrenumber.rsto enforce that renumbering to invalid destination file descriptors is an error.If we want to align on return error codes between the runtimes for certain filesystem functions, I don't think it would be too much work to change the WAMR implementation to make it fall in line with wasmtime but for the moment have raised this PR to get some clarification and feedback.