-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PeriodicWave's constructor is not valid IDL #1116
Comments
In https://webaudio.github.io/web-audio-api/#periodicwaveoptions, the text says that one of real or imag dictionary member is required. Can that be expressed in IDL somehow? Or maybe we can default both of them to some sensible default and thus make both members truly optional? |
Not at the moment.
It's hard to say, because the behavior of this constructor is pretty much completely undefined. See #1120 |
In the teleconf, a couple of things were suggested:
|
You can't leave it as is, because as is is not valid IDL.... |
The proposal in PR #1116 is option 2: Make the dictionary optional, and specify what happens if both real and imag are not given. |
Fix #1116: Make PeriodicWaveOptions optional
The dictionary without required members in trailing position needs to be optional, per IDL.
The text was updated successfully, but these errors were encountered: