Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove options parameter from AudioWorkletProcessor constructor WebIDL #2044

Closed
karlt opened this issue Aug 22, 2019 · 3 comments · Fixed by #2102
Closed

Remove options parameter from AudioWorkletProcessor constructor WebIDL #2044

karlt opened this issue Aug 22, 2019 · 3 comments · Fixed by #2102
Assignees
@hoch
Labels
status: ready for editing
Projects
V1
Milestone
Web Audio V1

Comments

@karlt
Copy link
Contributor

karlt commented Aug 22, 2019

This is a follow-up to #2036.
The parameter has been removed from the description at https://webaudio.github.io/web-audio-api/#dom-audioworkletprocessor-audioworkletprocessor but not from the IDL at https://webaudio.github.io/web-audio-api/#ref-for-dom-audioworkletprocessor-audioworkletprocessor%E2%91%A0
@hoch hoch added this to Untriaged in V1 Aug 29, 2019
@rtoy rtoy added this to the Web Audio V1 milestone Aug 29, 2019
@hoch
Copy link
Member

hoch commented Aug 29, 2019

TODO:
https://webaudio.github.io/web-audio-api/#callbackdef-audioworkletprocessorconstructor

@hoch hoch moved this from Untriaged to Ready for Editing in V1 Aug 29, 2019
@karlt
Copy link
Contributor Author

karlt commented Aug 29, 2019 •
edited
Loading

TODO:
https://webaudio.github.io/web-audio-api/#callbackdef-audioworkletprocessorconstructor

I assume we don't want to change that one. We want the AudioWorkletProcessorConstructor callback to receive the options.

@hoch hoch mentioned this issue Nov 20, 2019
Merged
@hoch
Copy link
Member

hoch commented Nov 22, 2019

Closed by #2102.

@hoch hoch closed this as completed Nov 22, 2019
V1 automation moved this from Ready for Editing to Done Nov 22, 2019
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Feb 6, 2020
@padenot
Bug 1569809 - Remove AudioNodeOptions from the ctor of AudioWorkletPr…
2274684 
…ocessor. r=baku

This was changed in WebAudio/web-audio-api#2044

Differential Revision: https://phabricator.services.mozilla.com/D61714

--HG--
extra : moz-landing-system : lando
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Feb 6, 2020
@padenot
Bug 1569809 - Remove AudioNodeOptions from the ctor of AudioWorkletPr…
c112a0d 
…ocessor. r=baku

This was changed in WebAudio/web-audio-api#2044

Differential Revision: https://phabricator.services.mozilla.com/D61714
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Feb 12, 2020
@marco-c
Bug 1569809 - Remove AudioNodeOptions from the ctor of AudioWorkletPr…
ea3eeb0 
…ocessor. r=baku

This was changed in WebAudio/web-audio-api#2044

Differential Revision: https://phabricator.services.mozilla.com/D61714

UltraBlame original commit: e5d00323e175b7369471a0d9f9403b6898afb3f4
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Feb 12, 2020
@marco-c
Bug 1569809 - Remove AudioNodeOptions from the ctor of AudioWorkletPr…
458b5cc 
…ocessor. r=baku

This was changed in WebAudio/web-audio-api#2044

Differential Revision: https://phabricator.services.mozilla.com/D61714

UltraBlame original commit: e5d00323e175b7369471a0d9f9403b6898afb3f4
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Feb 12, 2020
@marco-c
Bug 1569809 - Remove AudioNodeOptions from the ctor of AudioWorkletPr…
7703ba4 
…ocessor. r=baku

This was changed in WebAudio/web-audio-api#2044

Differential Revision: https://phabricator.services.mozilla.com/D61714

UltraBlame original commit: e5d00323e175b7369471a0d9f9403b6898afb3f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoch hoch

Labels
status: ready for editing
Projects
No open projects
V1
  
Done
Milestone
Web Audio V1
Development

Successfully merging a pull request may close this issue.

Remove options from the AudioWorkletProcessor constructor hoch/web-audio-api
3 participants
@rtoy @hoch @karlt