Remove options from the AudioWorkletProcessor constructor
#2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtoy
reviewed
Nov 20, 2019
There was a problem hiding this comment.
I think you might also need to update https://webaudio.github.io/web-audio-api/#dictdef-audioworkletnodeoptions since the first paragraph says it's used with AudioWorkletProcessor.
|
Technically it is indirectly used with AWP. |
|
Yes, but the way its phrased makes it sound like the developer can give it directly to the processor constructor. That's not possible now, IIUC. |
|
@rtoy Done. Could you take one more look? |
rtoy
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2044.
cc @karlt
Preview | Diff