Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing doppler effect from PannerNode #455

Closed
rtoy opened this issue Dec 9, 2014 · 1 comment
Closed

Removing doppler effect from PannerNode #455

rtoy opened this issue Dec 9, 2014 · 1 comment

Comments

@rtoy
Copy link
Member

rtoy commented Dec 9, 2014

In #372, there is a discussion about removing the doppler effect from the PannerNode, and it was agreed upon at TPAC to remove this.

Does this mean that the setVelocity method is also removed?

@cwilso
Copy link
Contributor

cwilso commented Dec 9, 2014

Removing Doppler in the reworked pannernode will mean there will be no setVelocity on the new PannerNode (ThreeDPannerNode? Panner3DNode? SpatialPannerNode?)

The AudioListener will also lose its dopplerFactor and speedOfSound attributes.

@cwilso cwilso closed this as completed Dec 9, 2014
momchil-velikov pushed a commit to eth-sri/BlinkER that referenced this issue Jan 14, 2015
The W3C audio group has agreed to remove the doppler effect from
panner nodes. This also means removing the doppler-related attributes
and methods from AudioListener.

See WebAudio/web-audio-api#455

This just deprecates the attributes and methods from the IDL.  The
underlying implementation still has support for this.  We prefer to
remove these all at once when the PannerNode (soon to be deprecated)
is completely removed.

Manually verified the attributes and method cause deprecation warnings.

BUG=439644

Review URL: https://codereview.chromium.org/799023002

git-svn-id: svn://svn.chromium.org/blink/trunk@187218 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants