Fix #1880: setOrientation description #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Apply simple fix to setOrientation and setPosition paragraphs * Add some very simple descriptive text for the parameters of the methods * Add links to the method parameters in the method descriptions.
hoch
approved these changes
May 15, 2019
| <b>front</b> vector represents which direction the person's | ||
| nose is pointing. The <b>up</b> vector represents the direction | ||
| {{AudioListener/setOrientation()}} describes which direction the listener is pointing in the 3D | ||
| cartesian coordinate space. Both a [=front=] vector and an |
There was a problem hiding this comment.
I guess [=front=] is defined above?
| {{AudioListener/setOrientation()}} describes which direction the listener is pointing in the 3D | ||
| cartesian coordinate space. Both a [=front=] vector and an | ||
| [=up=] vector are provided. In simple human terms, the | ||
| <dfn dfn>front</dfn> vector represents which direction the person's |
There was a problem hiding this comment.
Yeah, this is the definition. Kind of bad to have a forward definition, but I didn't want to restructure everything, and just made explicit links between uses and the definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff