Fix #2147: Clean up PeriodicWave constructor #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up the constructor for PeriodicWave based on the algorithm given in WebAudio#2147 (comment). A few other minor cleanups in the algorithm description were also done: * Move declaration of `[[real]]`, `[[imag]]`, and `[[normalize]]` to the beginning of the algorithm. * Remove extra text for the members of the `PeriodicWaveOptions` to the algorithm so that everthing is all in one place.
|
@bzbarsky PTAL to see if I missed anything. |
bzbarsky
approved these changes
Feb 19, 2020
|
Thanks for your review @bzbarsky. I've applied all of your suggestions. |
padenot
approved these changes
Feb 20, 2020
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the constructor for PeriodicWave based on the algorithm given in
#2147 (comment).
A few other minor cleanups in the algorithm description were also done:
[[real]],[[imag]], and[[normalize]]to the beginning of the algorithm.PeriodicWaveOptionsto the algorithm so that everthing is all in one place.Preview | Diff