Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2147: Clean up PeriodicWave constructor #2168

Merged
merged 4 commits into from Feb 20, 2020

Commits on Feb 18, 2020

  1. Fix WebAudio#2147: Clean up PeriodicWave constructor

    Cleans up the constructor for PeriodicWave based on the algorithm
    given in
    WebAudio#2147 (comment).
    
    A few other minor cleanups in the algorithm description were also
    done:
    *  Move declaration of `[[real]]`, `[[imag]]`, and `[[normalize]]` to
       the beginning of the algorithm.
    * Remove extra text for the members of the `PeriodicWaveOptions` to
      the algorithm so that everthing is all in one place.
    rtoy committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    b407ce4 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2020

  1. Fix typos

    rtoy committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    43a8ce8 View commit details
    Browse the repository at this point in the history
  2. Fix more typos

    rtoy committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    0d6b3df View commit details
    Browse the repository at this point in the history
  3. Address comments from bzbarsky.

    rtoy committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    33332d6 View commit details
    Browse the repository at this point in the history