Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for requesting devices with specific service data in adv packets #294

Closed
irgu opened this issue Sep 13, 2016 · 5 comments · Fixed by #297
Closed

Support for requesting devices with specific service data in adv packets #294

irgu opened this issue Sep 13, 2016 · 5 comments · Fixed by #297

Comments

@irgu
Copy link

irgu commented Sep 13, 2016 •
edited
Loading

Is there any plan to add filtering by specific service data? I mean something like bit mask filter for requesting devices with specific pattern inside the service data.
@beaufortfrancois
Copy link
Member

Current implementation for filtering service data and manufacturer data is pretty simple. However, we've talked about adding masks as you can read at #153 (comment)

May I ask what is your use case?

@irgu
Copy link
Author

irgu commented Sep 17, 2016

Mentioned comment perfectly applies to what I'm looking for. In my case I have proprietary application level packets encapsulated in service data.

@beaufortfrancois
Copy link
Member

@jyasskin Should we add masks to the spec now then?

@jyasskin jyasskin mentioned this issue Sep 23, 2016
Merged
@beaufortfrancois
Copy link
Member

@irgu Feel free to comment on #297

jyasskin added a commit that referenced this issue Sep 27, 2016
@jyasskin
Accept filters on manufacturer and service data. (#297)
36a5e51 
This should take advantage of WebIDL open dictionaries when they're spec'ed, but we're not waiting on https://www.w3.org/Bugs/Public/show_bug.cgi?id=20158.

Fixes #294
@beaufortfrancois
Copy link
Member

@irgu Is this still something you're interested in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accept filters on manufacturer and service data. jyasskin/web-bluetooth-1
2 participants
@beaufortfrancois @irgu