Throw an exception if requestDevice() filters include no services #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of silently returning no devices. Fixes WebBluetoothCG#142.
jyasskin
force-pushed
the
loud-empty-filters
branch
from
c189c76
to
c9d7f70
Compare
| @@ -24,6 +24,14 @@ This document attempts to explain why various decisions were made the way they w | |||
| * While the <a>Server</a> role can work in a <a>Central</a> device, | |||
| <a>Client</a> is more natural and is required for more use cases. | |||
|
|
|||
| ## Why does `requestDevice()` require non-empty filters? | |||
There was a problem hiding this comment.
I think requestDevice is sufficient, and that adding Matching doesn't add value to warrant the name complexity.
|
LGTM, though I offer a possible further explanation https://github.com/WebBluetoothCG/web-bluetooth/pull/144/files#r35387445 |
jyasskin
added a commit
that referenced
this pull request
Jul 24, 2015
Throw an exception if requestDevice() filters include no services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of silently returning no devices.
Fixes #142.
Demo at https://rawgit.com/jyasskin/web-bluetooth-1/loud-empty-filters/index.html. @beaufortfrancois @scheib