Enforce that the current realm is connected while running GATT procedures. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yrliou @BruceSunMozilla this PR affects how you'll implement disconnection. |
| even if the UA stays connected the whole time | ||
| and the {{BluetoothRemoteGATTServer}} is subsequently re-connected before they finish. | ||
| We wrap the returned {{Promise}} to accomplish this. | ||
| </span> |
There was a problem hiding this comment.
Should we put the note in a separate paragraph?
jyasskin
force-pushed
the
enforce-connectedness
branch
from
c80f37d
to
2a2cb3b
Compare
…ures. This change makes it so that a disconnect() call takes effect immediately and prevents any subsequent changes to member variables from a returning GATT procedure, even if the GATT procedure started before the disconnection. It also forces all active requests to fail with a NetworkError so that no remnants of the connection keep running after it's terminated. This reverses the readValue() promise and event order from WebBluetoothCG#175, in order to avoid needing to perform a microtask checkpoint inside the algorithm. Fixes WebBluetoothCG#114. Fixes WebBluetoothCG#171.
jyasskin
force-pushed
the
enforce-connectedness
branch
from
2a2cb3b
to
6ebe5f0
Compare
|
lgtm |
jyasskin
added a commit
that referenced
this pull request
Mar 9, 2016
Enforce that the current realm is connected while running GATT procedures.
|
As discussed in #274 (comment), I don't like the order "fire event then resolve promise" since that makes it impossible to distinguish notifications from read responses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that a disconnect() call takes effect immediately and
prevents any subsequent changes to member variables from a returning GATT
procedure, even if the GATT procedure started before the disconnection. It also
forces all active requests to fail with a NetworkError so that no remnants of
the connection keep running after it's terminated.
This reverses the readValue() promise and event order from #175, in order to
avoid needing to perform a microtask checkpoint inside the algorithm.
Fixes #114 and #171.
Preview at https://rawgit.com/jyasskin/web-bluetooth-1/enforce-connectedness/index.html.