Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce that the current realm is connected while running GATT procedures. #209

Merged
merged 2 commits into from
Mar 9, 2016
Merged

Enforce that the current realm is connected while running GATT procedures. #209

merged 2 commits into from
Mar 9, 2016

Commits on Mar 8, 2016

  1. Enforce that the current realm is connected while running GATT proced… 

    …ures.

This change makes it so that a disconnect() call takes effect immediately and
prevents any subsequent changes to member variables from a returning GATT
procedure, even if the GATT procedure started before the disconnection. It also
forces all active requests to fail with a NetworkError so that no remnants of
the connection keep running after it's terminated.

This reverses the readValue() promise and event order from WebBluetoothCG#175, in order to
avoid needing to perform a microtask checkpoint inside the algorithm.

Fixes WebBluetoothCG#114. Fixes WebBluetoothCG#171.
    @jyasskin
    jyasskin committed Mar 8, 2016
    Configuration menu
    Copy the full SHA
    7d590ba View commit details
    Browse the repository at this point in the history

  2. Put the connection-checking wrapper note in its own paragraph.

    @jyasskin
    jyasskin committed Mar 8, 2016
    Configuration menu
    Copy the full SHA
    6ebe5f0 View commit details
    Browse the repository at this point in the history