Also fire gattserverdisconnected when a page disconnects itself.
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ack, nice. |
|
I'll update https://googlechrome.github.io/samples/web-bluetooth/device-disconnect.html as well to remove the |
|
LGTM, with possible additional suggestion of explicitly mentioning that a duplicate event must not arrive when the device is disconnected by the OS. |
|
+1 |
… the device isn't connected.
jyasskin
force-pushed
the
fire-disconnected-on-disconnect
branch
from
2b17625
to
495cedd
Compare
|
@scheib Thanks, done. |
jyasskin
added a commit
that referenced
this pull request
Mar 8, 2016
Also fire `gattserverdisconnected` when a page disconnects itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #215.
@thegecko