Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertion that Peripherals can only receive one connection. #92

Merged

Conversation

jyasskin
Copy link
Member

@g-ortuno @armansito

I suspect we should rewrite the Introduction to be more explanatory, but this'll fix the immediate issue.

The <dfn>Peripheral</dfn> role is able to receive a single connection.
The <dfn>Central</dfn> role supports multiple connections,
and is responsible for creating any connections to <a>Peripheral</a> devices.
Devices acting in the <dfn>Peripheral</dfn> role can receive connections,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "can receive multiple connections"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That depends on the controller, right? Not all Peripherals will be able to accept multiple connections, especially since we're hoping to support BT4.0 devices with this spec.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the meaning of can receive connections the same as can receive multiple connections, except the latter is clearer? If BT4.0 is a concern what about: can receive one or, if supported, multiple connections. Either way, I'm definitely nitpicking here, if the intro is gonna be rewritten then this LGTM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the introduction, I'm not really going for precision, just the general idea to help people navigate the rest of the spec. Even the full list of possible roles might be too much.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could try and start to use the terms Master and Slave, which device started the connection is not hugely important and it is highly likely that all devices will soon have a GATT Database, so the usefulness of the terms Peripheral and Central terms become less useful and at worst are misleading.

jyasskin added a commit that referenced this pull request Apr 1, 2015
Fix assertion that Peripherals can only receive one connection.
@jyasskin jyasskin merged commit 534c63f into WebBluetoothCG:gh-pages Apr 1, 2015
@jyasskin jyasskin deleted the peripheral-multi-connections branch April 1, 2015 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants