Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertion that Peripherals can only receive one connection. #92

Merged
merged 1 commit into from Apr 1, 2015
Merged

Fix assertion that Peripherals can only receive one connection. #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions index.html
View file
Open in desktop
Expand Up @@ -126,9 +126,9 @@ <h2>Introduction</h2>
BTLE defines multiple roles that devices can play.
The <dfn>Broadcaster</dfn> and <dfn>Observer</dfn> roles are
for transmitter- and receiver-only applications, respectively.
The <dfn>Peripheral</dfn> role is able to receive a single connection.
The <dfn>Central</dfn> role supports multiple connections,
and is responsible for creating any connections to <a>Peripheral</a> devices.
Devices acting in the <dfn>Peripheral</dfn> role can receive connections,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "can receive multiple connections"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That depends on the controller, right? Not all Peripherals will be able to accept multiple connections, especially since we're hoping to support BT4.0 devices with this spec.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the meaning of can receive connections the same as can receive multiple connections, except the latter is clearer? If BT4.0 is a concern what about: can receive one or, if supported, multiple connections. Either way, I'm definitely nitpicking here, if the intro is gonna be rewritten then this LGTM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the introduction, I'm not really going for precision, just the general idea to help people navigate the rest of the spec. Even the full list of possible roles might be too much.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could try and start to use the terms Master and Slave, which device started the connection is not hugely important and it is highly likely that all devices will soon have a GATT Database, so the usefulness of the terms Peripheral and Central terms become less useful and at worst are misleading.

and devices acting in the <dfn>Central</dfn> role can connect to <a>Peripheral</a> devices.
</p>

<p>
<dfn>GATT</dfn> further defines <dfn>Client</dfn> and <dfn>Server</dfn> roles,
Expand Down