Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support php 7.4 #554

Merged
merged 2 commits into from
Oct 17, 2020
Merged

Update to support php 7.4 #554

merged 2 commits into from
Oct 17, 2020

Conversation

aubreypwd
Copy link
Contributor

@aubreypwd aubreypwd commented Oct 16, 2020

No Ticket

DESCRIPTION

  • Updates to 1.2.0 of our php coding standards to support php 7.4

OTHER

  • Is this issue accessible? (Section 508/WCAG 2.0AA)
  • Does this issue pass all the linting? (PHPCS, ESLint, SassLint)
  • Does this pass CBT?

STEPS TO VERIFY

  • Clone
  • composer install
  • composer run lint

wdsccsphp74

Copy link
Contributor Author

@aubreypwd aubreypwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review complete.

@@ -91,7 +91,7 @@ function _s_copyright_year( $atts ) {
$atts
);

$current_year = date( 'Y' );
$current_year = gmdate( 'Y' );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the update to wpcs, this lint failed, so fixed.

@aubreypwd aubreypwd self-assigned this Oct 16, 2020
@aubreypwd aubreypwd linked an issue Oct 16, 2020 that may be closed by this pull request
4 tasks
@gregrickaby gregrickaby merged commit 0c965b8 into main Oct 17, 2020
@gregrickaby gregrickaby deleted the feature/tailwind branch October 17, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for WDS Coding Standards
2 participants