Solve to SqlAction in DbConstraintSolver using SqlActionBuilder #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agusaldasoro
changed the title
arcuri82
requested changes
Feb 7, 2024
| @@ -35,6 +35,16 @@ | |||
| <groupId>org.evomaster</groupId> | |||
| <artifactId>evomaster-client-java-sql</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.evomaster</groupId> | |||
There was a problem hiding this comment.
add comment that this creates a circular dependency.
in long run, we don't want this module to depend on core, if want to use it outside of EM.
fine for now, but future might need an intermediate representation X (eg convertion from X to SqlAction would be done inside core)
There was a problem hiding this comment.
or we might move this module directly inside core... let's leave it here for now, we can think about its integration later on
There was a problem hiding this comment.
Oh, okay! Will leave a comment with that info, thanks!
Support for more than one variable
Refactor Solver to use db schema
arcuri82
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
DbConstraintSolverto return a list ofSqlActioninstead of a string