Fix Cross-platform issue with npm script #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issackjohn
requested review from
lpardosixtosMs,
bgrins,
rniwa and
flashdesignory
rniwa
approved these changes
Mar 7, 2024
julienw
approved these changes
Mar 7, 2024
camillobruni
approved these changes
Mar 7, 2024
webkit-commit-queue
pushed a commit
to rniwa/WebKit
that referenced
this pull request
Mar 7, 2024
https://bugs.webkit.org/show_bug.cgi?id=270626 Reviewed by Anne van Kesteren. Merge WebKit/Speedometer#397 into browserbench.org. * Websites/browserbench.org/Speedometer3.0/package.json: * Websites/browserbench.org/Speedometer3.0/tests/run.mjs: Canonical link: https://commits.webkit.org/275782@main
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #396
This change allows the npm test scripts to also run on windows machines.
The PR:
(e.g., BROWSER=chrome node tests/run.mjs). However, this PR alters the approach to use command line arguments instead(e.g., node tests/run.mjs --browser chrome).npm run formatwork as well.