-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cherry-pick ef22954. rdar://117905809
Use GlyphData.isValid() consistently for checking whether GlyphData is valid. https://bugs.webkit.org/show_bug.cgi?id=264130 rdar://117905809 Reviewed by Tim Nguyen. Replace GlyphData validity checks using .glyph and .font directly with .isValid(). Make .isValid() return false even if .glyph is non-zero and .font is null (which should never happen) since a .font null check isn't expensive anyway. * Source/WebCore/platform/graphics/FontCascade.cpp: (WebCore::FontCascade::fontForCombiningCharacterSequence const): * Source/WebCore/platform/graphics/FontCascadeFonts.cpp: (WebCore::FontCascadeFonts::GlyphPageCacheEntry::setGlyphDataForCharacter): (WebCore::FontCascadeFonts::glyphDataForSystemFallback): (WebCore::FontCascadeFonts::glyphDataForVariant): (WebCore::FontCascadeFonts::glyphDataForCharacter): * Source/WebCore/platform/graphics/FontRanges.cpp: (WebCore::FontRanges::glyphDataForCharacter const): * Source/WebCore/platform/graphics/GlyphPage.h: (WebCore::GlyphData::isValid const): Canonical link: https://commits.webkit.org/270299@main Identifier: 267815.552@safari-7617.1.17.11-branch
- Loading branch information
Dan Robson
committed
Nov 9, 2023
1 parent
a42f1a7
commit 161dd79
Showing
4 changed files
with
9 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters