-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[WebAuthn] WebKitTestRunner/TWAPI lacks an entitlement and bundle ide…
…ntifier to use required [ASCAgent performAuthorizationRequestsForContext] https://bugs.webkit.org/show_bug.cgi?id=232846 rdar://problem/85170633 Reviewed by Brent Fulgham. Covered by existing tests. Calling to ASC requires converting WebAuthenticationRequestData to ASCCredentialRequestContext and then making a call to _WKAuthenticatorAssertionResponse, while also requiring entitlements currently unavailable in OpenSource. This change avoids calling out to ASC in tests using mock / virtual authenticators to avoid this problem, the serialization to and from ASCAgent can be tested seperately. * UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: Refactor creation of ASCCredentialRequestContext. (WebKit::WebAuthenticatorCoordinatorProxy::isUserVerifyingPlatformAuthenticatorAvailable): * UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp: (WebKit::WebAuthenticatorCoordinatorProxy::handleRequest): Refactor use of ASC and add clarifying comment about flow. Canonical link: https://commits.webkit.org/244290@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
4 changed files
with
45 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters