Skip to content

Commit

Permalink
[ iOS Debug ] fast/screen-orientation/natural-orientation.html and fa…
Browse files Browse the repository at this point in the history
…st/events/ios/rotation/zz-no-rotation.html test are constant failures

https://bugs.webkit.org/show_bug.cgi?id=269630
rdar://123124639

Reviewed by Tim Nguyen.

Update the width, height, and orientation angle values as reported by the simulators.

* LayoutTests/fast/events/ios/rotation/zz-no-rotation-expected.txt:
* LayoutTests/fast/events/ios/rotation/zz-no-rotation.html:
* LayoutTests/platform/ios-wk2/TestExpectations:
* LayoutTests/platform/ios/fast/events/ios/rotation/zz-no-rotation-expected.txt:
* LayoutTests/platform/ipad/TestExpectations:
* LayoutTests/platform/ipad/fast/events/ios/rotation/zz-no-rotation-expected.txt:
* LayoutTests/platform/ipad/fast/screen-orientation/natural-orientation-expected.txt: Added.

Canonical link: https://commits.webkit.org/275677@main
  • Loading branch information
marcoscaceres committed Mar 5, 2024
1 parent 4e349ca commit 1f38182
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 12 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
CONSOLE MESSAGE: window.innerWidth: 390
CONSOLE MESSAGE: window.innerHeight: 797
PASS successfullyParsed is true

TEST COMPLETE
PASS window.innerWidth is 320
PASS window.innerHeight is 548
This test checks that the view is not left in a rotated state after the previous tests.
4 changes: 2 additions & 2 deletions LayoutTests/fast/events/ios/rotation/zz-no-rotation.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
<script>
function doTest()
{
shouldBe("window.innerWidth", "320");
shouldBe("window.innerHeight", "548");
console.log(`window.innerWidth: ${window.innerWidth}`);
console.log(`window.innerHeight: ${window.innerHeight}`);
}
window.addEventListener('load', doTest, false);
</script>
Expand Down
3 changes: 1 addition & 2 deletions LayoutTests/platform/ios-wk2/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2131,8 +2131,7 @@ webkit.org/b/266630 imported/w3c/web-platform-tests/trusted-types/trusted-types-
webkit.org/b/266630 imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-report-only.html [ Skip ]
webkit.org/b/266630 imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-no-unsafe-eval.html [ Skip ]

# rdar://97297483 ([ iOS16 ] fast/events/ios/rotation/zz-no-rotation.html is a constant timeout =)
fast/events/ios/rotation/zz-no-rotation.html [ Timeout ]
fast/events/ios/rotation/zz-no-rotation.html [ Pass Crash ]

webkit.org/b/210849 compositing/overflow/rtl-scrollbar-layer-positioning.html [ Pass Timeout ]

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
CONSOLE MESSAGE: window.innerWidth: 390
CONSOLE MESSAGE: window.innerHeight: 797
PASS successfullyParsed is true

TEST COMPLETE
FAIL window.innerWidth should be 320. Was 390.
FAIL window.innerHeight should be 548. Was 797.
This test checks that the view is not left in a rotated state after the previous tests.
4 changes: 2 additions & 2 deletions LayoutTests/platform/ipad/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ media/mediacapabilities/mediacapabilities-allowed-containers.html [ Pass ]

# webkit.org/b/269393 ([ iOS wk2 ] 3 iOS orientation(layout-tests) are constant text failures)
compositing/backing/page-scale-overlap-in-iframe.html [ Failure ]
fast/events/ios/rotation/zz-no-rotation.html [ Failure ]
fast/screen-orientation/natural-orientation.html [ Failure ]
fast/events/ios/rotation/zz-no-rotation.html [ Pass Crash ]
fast/screen-orientation/natural-orientation.html [ Pass ]

# webkit.org/b/269417 ([ iOS ] 5x imported/w3c/web-platform-tests are constant text failures)
imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html [ Failure ]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
CONSOLE MESSAGE: window.innerWidth: 810
CONSOLE MESSAGE: window.innerHeight: 1060
PASS successfullyParsed is true

TEST COMPLETE
FAIL window.innerWidth should be 320. Was 768.
FAIL window.innerHeight should be 548. Was 1004.
This test checks that the view is not left in a rotated state after the previous tests.
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Natural screen orientation should be landcape-primary on Desktop

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


Default orientation is portrait-primary.
Default angle is 90.
PASS successfullyParsed is true

TEST COMPLETE

0 comments on commit 1f38182

Please sign in to comment.