-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
WKWebExtensionAPITabs.ExecuteScript test has a race condition and fai…
…ls sometimes. https://webkit.org/b/264754 rdar://problem/118344217 Reviewed by Brian Weinstein. Use the onUpdated or onCompleted events to know when the tab navigates so we can execute script. Also properly fire the onUpdated event by using web view navigation delegate methods. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm: (-[TestWebExtensionTab initWithWindow:extensionController:]): Set navigationDelegate. (-[TestWebExtensionTab changeWebViewIfNeededForURL:forExtensionContext:]): Ditto. (-[TestWebExtensionTab webView:didStartProvisionalNavigation:]): Added. (-[TestWebExtensionTab webView:didReceiveServerRedirectForProvisionalNavigation:]): Added. (-[TestWebExtensionTab webView:didFailNavigation:withError:]): Added. (-[TestWebExtensionTab webView:didCommitNavigation:]): Added. (-[TestWebExtensionTab webView:didFinishNavigation:]): Added. (-[TestWebExtensionTab setParentTab:forWebExtensionContext:completionHandler:]): Added cast to fix error. Canonical link: https://commits.webkit.org/270658@main
- Loading branch information
Showing
3 changed files
with
121 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters