Skip to content

Commit

Permalink
[Build] WebGPU uses @rpath in debug builds, causing shared cache elig…
Browse files Browse the repository at this point in the history
…ibility errors

https://bugs.webkit.org/show_bug.cgi?id=266443
rdar://119687134

Reviewed by Mike Wyrzykowski.

Remove WebGPU's @rpath install name. No other WebKit frameworks use
@rpath in their install name, even in Debug builds when
WK_RELOCATABLE_FRAMEWORKS is set, because debug build workflows always
use DYLD_FRAMEWORK_PATH to override the install names recorded in linked
binaries.

* Source/WebGPU/Configurations/WebGPU.xcconfig:

Canonical link: https://commits.webkit.org/272102@main
  • Loading branch information
emw-apple authored and graouts committed Dec 15, 2023
1 parent 694cea7 commit 273f225
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions Source/WebGPU/Configurations/WebGPU.xcconfig
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,7 @@ INFOPLIST_FILE = Info.plist;

INSTALL_PATH = $(INSTALL_PATH_PREFIX)$(WEBGPU_FRAMEWORKS_DIR);

DYLIB_INSTALL_NAME_BASE = $(DYLIB_INSTALL_NAME_BASE_$(CONFIGURATION));
DYLIB_INSTALL_NAME_BASE_Production = $(DYLIB_INSTALL_NAME_BASE_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
DYLIB_INSTALL_NAME_BASE_Debug = @rpath;
DYLIB_INSTALL_NAME_BASE_Release = $(DYLIB_INSTALL_NAME_BASE_Debug);
DYLIB_INSTALL_NAME_BASE = $(DYLIB_INSTALL_NAME_BASE_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
DYLIB_INSTALL_NAME_BASE_NO = $(NORMAL_WEBGPU_FRAMEWORKS_DIR);
DYLIB_INSTALL_NAME_BASE_YES = $(WEBGPU_FRAMEWORKS_DIR);

Expand Down

0 comments on commit 273f225

Please sign in to comment.