Skip to content
Permalink
Browse files
REGRESSION(r275810): [WebKitTestRunner] fast/text/basic/004.html fail…
…s after running fast/layoutformattingcontext tests

https://bugs.webkit.org/show_bug.cgi?id=225087

Reviewed by Don Olmstead.

fast/layoutformattingcontext tests enable some internal debug
settings by using the test file header. These settings weren't
reset after running the tests.

r275810 changed resetPreferencesToConsistentValues not to call
WKPreferencesResetAllInternalDebugFeatures.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
Call WKPreferencesResetAllInternalDebugFeatures.

Canonical link: https://commits.webkit.org/237265@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
fujii committed May 3, 2021
1 parent cbb96fd commit 29dcd7af421a43ceac90e522ca286b9644da2b5e
Showing 2 changed files with 20 additions and 0 deletions.
@@ -1,3 +1,21 @@
2021-05-03 Fujii Hironori <Hironori.Fujii@sony.com>

REGRESSION(r275810): [WebKitTestRunner] fast/text/basic/004.html fails after running fast/layoutformattingcontext tests
https://bugs.webkit.org/show_bug.cgi?id=225087

Reviewed by Don Olmstead.

fast/layoutformattingcontext tests enable some internal debug
settings by using the test file header. These settings weren't
reset after running the tests.

r275810 changed resetPreferencesToConsistentValues not to call
WKPreferencesResetAllInternalDebugFeatures.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
Call WKPreferencesResetAllInternalDebugFeatures.

2021-05-03 Tim Nguyen <ntim@apple.com>

Add committer status for "Tim Nguyen" in contributors.json
@@ -888,6 +888,8 @@ void TestController::resetPreferencesToConsistentValues(const TestOptions& optio
if (enableAllExperimentalFeatures)
WKPreferencesEnableAllExperimentalFeatures(preferences);

WKPreferencesResetAllInternalDebugFeatures(preferences);

WKPreferencesSetProcessSwapOnNavigationEnabled(preferences, options.shouldEnableProcessSwapOnNavigation());
WKPreferencesSetStorageBlockingPolicy(preferences, kWKAllowAllStorage); // FIXME: We should be testing the default.

0 comments on commit 29dcd7a

Please sign in to comment.