-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
REGRESSION (266237@main): Poster circle animation is not continuous https://bugs.webkit.org/show_bug.cgi?id=263569 <rdar://117209302> Reviewed by Simon Fraser. This is the same as the existing hasBig3DRotation rotation issue, where CA animates the shortest path between 3d rotations, because we represent them as matrices. Previously our computed matrices for rotate(180deg) didn’t have integer values, due to a float rounding issue during deg->rad. The new change computes the rotation matrix exactly, and now there’s no longer a defined direction for a 180deg rotation and we sometimes end up with a ‘backwards’ rotation. This adds an option to not do the snapping when we compute matrices for CA, so that the existing behavior is preserved. * Source/WebCore/platform/graphics/transforms/RotateTransformOperation.h: * Source/WebCore/platform/graphics/transforms/TransformOperation.h: (WebCore::TransformOperation::applyUnrounded const): * Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::rotate3d): (WebCore::TransformationMatrix::rotate): (WebCore::TransformationMatrix::rotateRadians): * Source/WebCore/platform/graphics/transforms/TransformationMatrix.h: Canonical link: https://commits.webkit.org/270294@main Identifier: 267815.550@safari-7617.1.17.11-branch
- Loading branch information
Dan Robson
committed
Nov 9, 2023
1 parent
cb09f82
commit 2c76486
Showing
4 changed files
with
37 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters